Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-pick #765] Retry to take full snapshot if prev full snapshot fails due to any reason. #767

Merged
merged 1 commit into from
Aug 30, 2024
Merged

[Cherry-pick #765] Retry to take full snapshot if prev full snapshot fails due to any reason. #767

merged 1 commit into from
Aug 30, 2024
+49 −21

Conversation

ishan16696
Copy link
Member

What this PR does / why we need it:
Cherry-pick PR : #765

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Retry to take full snapshot if the previous full snapshot operation fails.

@ishan16696
Retry to take full snapshot if prev full snapshot fails due to some r…
21416b1 
…eason. (gardener#765)

* Retry to take full snapshot if prev full snapshot fails.

* Retry with backoff.

* Move checking inside func IsFullSnapshotRequiredAtStartup().

* Fixed unit tests.

* Added unit test.

Address review comments.
@ishan16696 ishan16696 requested a review from a team as a code owner August 29, 2024 19:05
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 29, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 29, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 29, 2024
shreyas-s-rao
shreyas-s-rao approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 30, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 30, 2024
@ishan16696 ishan16696 merged commit f69d584 into gardener:rel-v0.28 Aug 30, 2024
9 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 30, 2024
@ishan16696 ishan16696 deleted the cherryPick-PR765 branch August 30, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renormalize renormalize renormalize approved these changes

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ishan16696 @shreyas-s-rao @renormalize @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot